chore: less brittle tests

2026-03-13 23:26:09 +03:00
parent c0846fe096
commit 5db211dda9
2 changed files with 7 additions and 2 deletions
@@ -34,6 +34,7 @@ def test_phone_auth_request_creates_customer_for_new_phone(client):

    otp = PhoneOTP.objects.get(id=data["request_id"])
    assert otp.phone_number == "+966512345678"
+    assert otp.channel == "sms"
    assert otp.purpose == OtpPurpose.AUTH


@@ -68,6 +69,8 @@ def test_phone_auth_request_rejects_email_already_used(client):
        email="taken@example.com",
    )

+    before_otp_count = PhoneOTP.objects.count()
+
    response = client.post(
        reverse("phone_auth_request"),
        {
@@ -81,7 +84,7 @@ def test_phone_auth_request_rejects_email_already_used(client):
    assert response.status_code == 400
    assert "detail" in response.json()
    assert User.objects.filter(phone_number="+966512345678").count() == 0
-    assert PhoneOTP.objects.filter(phone_number="+966512345678").count() == 0
+    assert PhoneOTP.objects.count() == before_otp_count


@pytest.mark.django_db