I proceeded with Phase 1 step 1 (phone-first auth + OTP hardening) and updated the plan context. Here’s the current state and the next steps.
What I implemented Phone-first auth endpoints with OTP → JWT issuance. views.py urls.py Phone normalization (KSA-focused, E.164 or Saudi mobile) and validation. phone.py serializers.py OTP protections: rate limit, resend cooldown, attempt counting. otp.py models.py Email is now optional to allow phone-only users. models.py 0002_phone_auth_fields.py Admin OTP visibility improved. admin.py Risks updated. risks.md
This commit is contained in:
@@ -15,12 +15,17 @@ class UserRole(models.TextChoices):
|
||||
|
||||
|
||||
class UserManager(BaseUserManager):
|
||||
def create_user(self, email, password=None, **extra_fields):
|
||||
if not email:
|
||||
raise ValueError("Email is required")
|
||||
email = self.normalize_email(email)
|
||||
def create_user(self, email=None, password=None, **extra_fields):
|
||||
phone_number = extra_fields.get("phone_number")
|
||||
if not email and not phone_number:
|
||||
raise ValueError("Email or phone number is required")
|
||||
if email:
|
||||
email = self.normalize_email(email)
|
||||
user = self.model(email=email, **extra_fields)
|
||||
user.set_password(password)
|
||||
if password:
|
||||
user.set_password(password)
|
||||
else:
|
||||
user.set_unusable_password()
|
||||
user.save(using=self._db)
|
||||
return user
|
||||
|
||||
@@ -36,7 +41,7 @@ class UserManager(BaseUserManager):
|
||||
|
||||
|
||||
class User(AbstractBaseUser, PermissionsMixin):
|
||||
email = models.EmailField(unique=True)
|
||||
email = models.EmailField(unique=True, null=True, blank=True)
|
||||
phone_number = models.CharField(max_length=20, unique=True, null=True, blank=True)
|
||||
role = models.CharField(max_length=20, choices=UserRole.choices, default=UserRole.CUSTOMER)
|
||||
first_name = models.CharField(max_length=150, blank=True)
|
||||
@@ -52,7 +57,7 @@ class User(AbstractBaseUser, PermissionsMixin):
|
||||
USERNAME_FIELD = "email"
|
||||
|
||||
def __str__(self):
|
||||
return self.email
|
||||
return self.email or self.phone_number or str(self.id)
|
||||
|
||||
|
||||
class OtpChannel(models.TextChoices):
|
||||
@@ -60,15 +65,23 @@ class OtpChannel(models.TextChoices):
|
||||
WHATSAPP = "whatsapp", "WhatsApp"
|
||||
|
||||
|
||||
class OtpPurpose(models.TextChoices):
|
||||
AUTH = "auth", "Authentication"
|
||||
VERIFY = "verify", "Phone Verification"
|
||||
|
||||
|
||||
class PhoneOTP(models.Model):
|
||||
id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=False)
|
||||
phone_number = models.CharField(max_length=20)
|
||||
channel = models.CharField(max_length=20, choices=OtpChannel.choices)
|
||||
purpose = models.CharField(max_length=20, choices=OtpPurpose.choices, default=OtpPurpose.AUTH)
|
||||
provider = models.CharField(max_length=50)
|
||||
code_hash = models.CharField(max_length=128)
|
||||
created_at = models.DateTimeField(auto_now_add=True)
|
||||
expires_at = models.DateTimeField()
|
||||
verified_at = models.DateTimeField(null=True, blank=True)
|
||||
attempt_count = models.PositiveSmallIntegerField(default=0)
|
||||
max_attempts = models.PositiveSmallIntegerField(default=5)
|
||||
|
||||
def is_expired(self):
|
||||
return timezone.now() >= self.expires_at
|
||||
|
||||
Reference in New Issue
Block a user